[PATCH] D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/CallingConvLower.cpp:94
     if (Fn(i, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, *this)) {
-#ifndef NDEBUG
-      dbgs() << "Formal argument #" << i << " has unhandled type "
-             << EVT(ArgVT).getEVTString() << '\n';
-#endif
-      llvm_unreachable(nullptr);
+      report_fatal_error("unable to allocate register");
     }
----------------
s/register/function argument/


================
Comment at: lib/CodeGen/CallingConvLower.cpp:122
     if (Fn(i, VT, VT, CCValAssign::Full, ArgFlags, *this)) {
-#ifndef NDEBUG
-      dbgs() << "Return operand #" << i << " has unhandled type "
-             << EVT(VT).getEVTString() << '\n';
-#endif
-      llvm_unreachable(nullptr);
+      report_fatal_error("unable to allocate register");
     }
----------------
s/register/function return/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64933/new/

https://reviews.llvm.org/D64933