[PATCH] D65016: Changes to emit CodeView debug info nested type records properly using MCStreamer directives

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, but please run git-clang-format before committing. Thanks!



================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:230
       Twine TComment(Comment);
-      Streamer->AddComment(TComment);
+      if(!TComment.isTriviallyEmpty())
+        Streamer->AddComment(TComment);
----------------
Please format


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp:142
   MemberKind = Record.Kind;
+  if(IO.isStreaming()) {
+    error(IO.mapEnum(Record.Kind, "Member kind: " + getLeafTypeName(Record.Kind)));
----------------
Please format


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp:403
+  if (IO.isStreaming()) {
+    if (auto EC = codeview::visitMemberRecordStream(Record.Data, *this))
+      return EC;
----------------
Oh, it's much easier than it seems, I guess. :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65016/new/

https://reviews.llvm.org/D65016