[PATCH] D65024: [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 15:56:13 PDT 2019


paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:1184
+  if (!Copy || Copy->getOpcode() != TargetOpcode::COPY)
+    return;
+  Register CopyDstReg = Copy->getOperand(0).getReg();
----------------
paquette wrote:
> aemerson wrote:
> > This pattern can now be replaced with getOpcodeDef()?
> It's not quite equivalent, since it looks through copies. I think that it would still work though, if I rejigger the rest of the function a bit.
Oh, wait, it looks for a specific opcode. I don't think that will work too well with copies.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65024/new/

https://reviews.llvm.org/D65024





More information about the llvm-commits mailing list