[PATCH] D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention

[Ryan Taylor via Phabricator via llvm-commits]

rtaylor marked 2 inline comments as done.
rtaylor added inline comments.


================
Comment at: lib/CodeGen/CallingConvLower.cpp:95-96
 #ifndef NDEBUG
       dbgs() << "Formal argument #" << i << " has unhandled type "
              << EVT(ArgVT).getEVTString() << '\n';
 #endif
----------------
arsenm wrote:
> The message printed here will still be wrong. 
It could still be an unhandled type? I'll just remove it.


================
Comment at: lib/CodeGen/CallingConvLower.cpp:98
 #endif
-      llvm_unreachable(nullptr);
+      report_fatal_error("unhandled type or register unavailable");
     }
----------------
arsenm wrote:
> I would rephrase this to be less specific. Unable to allocate function argument?
That's fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64933/new/

https://reviews.llvm.org/D64933