[PATCH] D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/CallingConvLower.cpp:95-96
 #ifndef NDEBUG
       dbgs() << "Formal argument #" << i << " has unhandled type "
              << EVT(ArgVT).getEVTString() << '\n';
 #endif
----------------
The message printed here will still be wrong. 


================
Comment at: lib/CodeGen/CallingConvLower.cpp:98
 #endif
-      llvm_unreachable(nullptr);
+      report_fatal_error("unhandled type or register unavailable");
     }
----------------
I would rephrase this to be less specific. Unable to allocate function argument?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64933/new/

https://reviews.llvm.org/D64933