[PATCH] D64503: LiveIntervals: Fix handleMove asserting on BUNDLE
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 19 12:05:46 PDT 2019
qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/CodeGen/LiveIntervals.cpp:1442
void LiveIntervals::handleMove(MachineInstr &MI, bool UpdateFlags) {
- assert(!MI.isBundled() && "Can't handle bundled instructions yet.");
+ assert((!MI.isBundled() || MI.getOpcode() == TargetOpcode::BUNDLE) &&
+ "Cannot move instruction in bundle");
----------------
Maybe add a comment saying that it is totally fine to move a bundle as a whole to better explain what the assert checks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64503/new/
https://reviews.llvm.org/D64503
More information about the llvm-commits
mailing list