[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 19 10:31:51 PDT 2019
sbc100 added a comment.
I'm not arguing against using yaml2obj in general, and obviously having binaries checked in is *almost* always a bad idea.
I'm only wondering if in this specific case it might make sense to keep binaries checked in, since we almost certainly never want them to change. Perhaps the point of these files is to be fixed in time forever to ensure we can parse basic object files. Ensuring that we can parse objects that we just created is kind of cheating maybe? I don't feel strongly about this. Does anyone else share this concern?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64800/new/
https://reviews.llvm.org/D64800
More information about the llvm-commits
mailing list