[PATCH] D64971: [SafeStack] Don't re-insert derefs for allocas in debug info

Fri Jul 19 10:31:43 PDT 2019

vsk added a comment.

In D64971#1593801 <https://reviews.llvm.org/D64971#1593801>, @probinson wrote:

> In D64971#1593796 <https://reviews.llvm.org/D64971#1593796>, @vsk wrote:
>
> > AFAICT the deref is always needed here: my understanding is that dbg.value has to describe the actual value of a variable, not its address (https://www.llvm.org/docs/LangRef.html#diexpression). I admit that keeping the deref may break the dwarf builder, but istm that indicates a bug in the dwarf builder.
>
>
> So the deref ought to go after the arithmetic, and not before.  Then someplace that knows the difference between values and locations can remove the deref so the resulting expression is ultimately correct in the DWARF?

Thanks, that's exactly what I mean.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64971/new/

https://reviews.llvm.org/D64971