[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D64800#1593490 <https://reviews.llvm.org/D64800#1593490>, @grimar wrote:

> Seems fine as is. (We do not want to swich `-h` to `--h`, right?)


No, not at all! -h is a single-letter option, so should have only one dash (see also -D for FileCheck).



================
Comment at: test/tools/llvm-readobj/coff-file-headers.test:3
+# RUN: llvm-readobj -h %t.arm \
+# RUN:  | FileCheck %s --strict-whitespace --match-full-lines --DFILE=%t.arm --check-prefix ARM
+
----------------
I think here -DFILE makes more sense, since it looks like compiler defines. -D is a short option too, so should have only a single dash.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64800/new/

https://reviews.llvm.org/D64800