[PATCH] D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 03:27:55 PDT 2019


critson marked an inline comment as done.
critson added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:5955-5959
+  case Intrinsic::amdgcn_softwqm: {
+    SDValue Src = Op.getOperand(1);
+    return SDValue(DAG.getMachineNode(AMDGPU::SOFT_WQM, DL, Src.getValueType(), Src),
+                   0);
+  }
----------------
arsenm wrote:
> Is there some reason you can't just handle this with an instruction pattern?
For the same reason as llvm.amdgcn.wqm, we don't specify the input and output types.
Happy to be corrected, but I don't think there is a way to have a single instruction pattern covering all types.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64935/new/

https://reviews.llvm.org/D64935





More information about the llvm-commits mailing list