[PATCH] D64936: [Local] Zap blockaddress without users in ConstantFoldTerminator.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 02:54:25 PDT 2019


fhahn added a comment.

In D64936#1593013 <https://reviews.llvm.org/D64936#1593013>, @grandinj wrote:

> Just a comment from a bystander:
>
> Isn't there some kind of verifier pass that clang runs (perhaps under some expensive-checks flag) after every pass?
>
> If such a thing exists, checking that BlockAddress nodes are properly cleaned seems like something it should do.


Excellent suggestion: I've added a check to the verifier (D64984 <https://reviews.llvm.org/D64984>) and it highlighted 2 other places where we need additional cleanups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64936/new/

https://reviews.llvm.org/D64936





More information about the llvm-commits mailing list