[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 19 02:45:13 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/coff-file-headers.test:33
+# ARM64:File: [[FILE]]
+# ARM64-NEXT:Format: COFF-ARM64
+# ARM64-NEXT:Arch: aarch64
----------------
MaskRay wrote:
> Due to `--strict-whitespace`, there are now no space after `NEXT:`. Just a question: do you find anything that requires `--strict-whitespace`?
In this patch we are testing how the headers are dumped.
And this is the main and the only test set atm for headers output I think. 
I supposed that we might want to check that do not print excessive spaces for example somewhere.
My feeling is not strong here though. I am OK to remove `--strict-whitespace` to make the tests nicer probably.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64800/new/

https://reviews.llvm.org/D64800





More information about the llvm-commits mailing list