[PATCH] D64939: Add a proposal for a libc project under the LLVM umbrella.

[JF Bastien via Phabricator via llvm-commits]

jfb added a comment.

There are some things in the libc++ docs that I think would be good to follow here: https://libcxx.llvm.org/docs/



================
Comment at: llvm/docs/Proposals/LLVMLibC.rst:25
+  upgrade of the C11 standard, llvm-libc is effectively C11 and
+  upwards conformant.
+- A modular libc with individual pieces implemented in the "as a
----------------
I'd drop this part: "llvm-libc is effectively C11 and upwards conformant."
I think it's mostly true, but not worth promising.

I do wonder: will it require passing `-std=c17` or later? That's mostly how libc++ works: the C++17 library features require C++17 language.


================
Comment at: llvm/docs/Proposals/LLVMLibC.rst:28
+  library" philosophy of the LLVM project.
+- Ability to layer this libc over the system libc.
+- Provide C symbols as specified by the standards, but take advantage
----------------
I think this is still pretty tentative, based on mailing list comments. Maybe say so here?


================
Comment at: llvm/docs/Proposals/LLVMLibC.rst:37
+  testing like fuzz testing and sanitizer-supported testing.
+- ABI independent implementation as far as possible.
+- Use source based implementations as far possible rather than
----------------
Will it be ABI-stable? Maybe it's worth expanding on how the ABI will evolve, and what will be stable.


================
Comment at: llvm/docs/Proposals/LLVMLibC.rst:71
+  compiler bugs rather than using assembly workarounds.
+- A large hole in the llvm toolchain will be plugged with llvm-libc.
+  With the broad platform expertise in the LLVM community, and the
----------------
Capitalize "llvm"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64939/new/

https://reviews.llvm.org/D64939