[PATCH] D64969: [llvm-objdump][NFC] Make the PrettyPrinter::printInst() output buffered

[James Henderson via Phabricator via llvm-commits]

jhenderson added reviewers: Bigcheese, jhenderson, rupprecht, grimar, MaskRay.
jhenderson added a comment.
Herald added a subscriber: dexonsmith.

I've added a few more reviewers for visibility.

My initial thought was "why not just delete the "flush"" from `printInst`, but I see that it's there for a "good" reason, looking at `PrettyPrinter`. I can't help but feel that a better solution would be to fix formatted_raw_ostream so that the indentation only gets added after any already-written content. Assuming that's not viable (e.g. it's intentional behaviour), I think what you have written works. @seiya, what are your thoughts on the formatted_raw_ostream implementation? Can it be sensibly changed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64969/new/

https://reviews.llvm.org/D64969