[PATCH] D64929: Don't update NoTrappingFPMath and FPDenormalMode in resetTargetOptions

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

I agree with this:

> We'd like to remove this whole function, because these are properties of functions

that's why this looks good to me.  Perhaps just a minor advance warning about this:

> These two are easy to remove because they are only used for emitting ARM build attributes

because build attributes and downstream math library selection issues was the whole reason to add this. 
If we don't set these build attributes, I am almost certain that without there will be downstream fall out because of this, so we might want to set these build attributes somewhere else (and indeed do it the right way).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64929/new/

https://reviews.llvm.org/D64929