[PATCH] D64952: [AMDGPU] Drop Reg32 and use regular AsmName

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 15:12:22 PDT 2019


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.td:58
   Register<n, !if(!eq(prefix, ""),
-                [ n, n, n, n, n, n, n, n ],
-                [ prefix # regNo,
-                  prefix # "[" # regNo # ":" # !and(!add(regNo, 1), 255) # "]",
+                [ n, n, n, n, n, n, n ],
+                [ prefix # "[" # regNo # ":" # !and(!add(regNo, 1), 255) # "]",
----------------
arsenm wrote:
> I noticed this is giving extra names to m0
Right, all registers in a class must support all altNameIndexes supported by that class. Thus special registers need to have names at every slot.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64952/new/

https://reviews.llvm.org/D64952





More information about the llvm-commits mailing list