[PATCH] D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 18:42:39 PDT 2019


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a couple nits fixed



================
Comment at: test/TableGen/FixedLenDecoderEmitter/InitValue.td:11
+
+let OutOperandList = (outs), Size = 2 in {
+
----------------
This is a bit confusing and isn't really doing anything helpful. For this test case, I'd prefer to just have the lets duplicated inside the defs.

Also, the formatting in this file isn't following the conventions used by most tablegen files (e.g. closing } being in the same column as the 'd' from def)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63741/new/

https://reviews.llvm.org/D63741





More information about the llvm-commits mailing list