[PATCH] D64927: lld-link: Demangle symbols from archives in diagnostics
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 18 15:53:55 PDT 2019
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/COFF/SymbolTable.h:86
Symbol *addUndefined(StringRef name, InputFile *f, bool isWeakAlias);
- void addLazy(ArchiveFile *f, const Archive::Symbol sym);
+ void addLazy(ArchiveFile *f, const Archive::Symbol& sym);
Symbol *addAbsolute(StringRef n, COFFSymbolRef s);
----------------
nit: `& ` -> ` &`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64927/new/
https://reviews.llvm.org/D64927
More information about the llvm-commits
mailing list