[PATCH] D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:877
+         "CandidateBB should dominate MBB1");
+  return MBFI->getBlockFreq(CandidateBB) <=
+         MBFI->getBlockFreq(MBB) + MBFI->getBlockFreq(MBB1);
----------------
I would suggest more conservative `<` instead of `<=` here. This essentially makes sense for the cases when all `BlockFreq`s are unknown (so they are equal to `0`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64394/new/

https://reviews.llvm.org/D64394