[PATCH] D64895: [GlobalISel] Translate calls to memcpy et al to G_INTRINSIC_W_SIDE_EFFECTs and legalize later.

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:1148
+  ICall.addImm(IsVol);
+  return true;
 }
----------------
arsenm wrote:
> aemerson wrote:
> > arsenm wrote:
> > > Should these get 1/2 mem operands?
> > Maybe for the alignments? I'm not sure about the volatile flag though, it seems to apply to the whole intrinsic not to specific pointer.
> Size, alignment, and IR object. I. guess you would have to propagate the volatile to both
Worth a try. However the size would have to be a lie, since the memory accessed would be potentially unknown. Perhaps that doesn't matter as it's an intrinsic and any code dealing with it would need to know not to never try to use the size info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64895/new/

https://reviews.llvm.org/D64895