[PATCH] D64950: [WebAssembly] Use passive segments by default when memory is shared

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: lld/wasm/Driver.cpp:324-326
+      args.hasFlag(OPT_passive_segments, OPT_active_segments, false) ||
+      (config->sharedMemory &&
+       !args.hasFlag(OPT_active_segments, OPT_passive_segments, false));
----------------
quantum wrote:
> This logic seems a bit hard to understand...
> 
> Would this work?
> 
>     args.hasFlag(OPT_passive_segments, OPT_active_segments, config->sharedMemory);
> 
Nice! I thought that bool was for something else entirely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64950/new/

https://reviews.llvm.org/D64950