[PATCH] D58484: [DO NOT SUBMIT] Add -vs-diagnostics.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: Common/ErrorHandler.cpp:89
+static std::string getLocation(std::string Msg, std::string Default) {
+  static std::vector<std::regex> Regexes{
+      std::regex(
----------------
ruiu wrote:
> MaskRay wrote:
> > How about using `llvm::Regex` instead of `std::regex`. I assume that may make the increased code size smaller.
> I'm not sure if we still should maintain llvm::Regex as I believe it is written before C++11. Maybe we should migrate to std::regex? I'm also not worried too much about the binary size, as lld already contains entire LLVM and std::regex shouldn't be too large.
FYI, this broke Chromium's packaging of clang: https://crbug.com/929645#c5
I think it's just time for us to upgrade to a newer GCC, so I don't think we should do anything here. But that won't stop me from shaking my fist at folks for creating work for us. =P


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58484/new/

https://reviews.llvm.org/D58484