[PATCH] D64946: [AMDGPU] Fix trivial PHI into SI_END_CF.

[Michael Liao via Phabricator via llvm-commits]

hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/lib/CodeGen/PHIElimination.cpp:203-204
   // Get an iterator to the last PHI node.
-  MachineBasicBlock::iterator LastPHIIt =
-    std::prev(MBB.SkipPHIsAndLabels(MBB.begin()));
-
----------------
arsenm wrote:
> arsenm wrote:
> > Wait, we already have isBasicBlockPrologue, and SkipPHIsAndLabels already checks it. Is it not returning true for SI_END_CF for some reason?
> I think to fixup the prolog uses a phi case, no new hook is necessary and can be done in terms of the existing one
that hook sounds to me should not modify anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64946/new/

https://reviews.llvm.org/D64946