[PATCH] D64934: Teach the IRBuilder about constrained FPTrunc and FPExt
Kevin P. Neal via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 18 11:01:45 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366477: [FPEnv] Teach the IRBuilder about constrained FPTrunc and FPExt (authored by kpn, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D64934?vs=210614&id=210638#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64934/new/
https://reviews.llvm.org/D64934
Files:
llvm/trunk/include/llvm/IR/IRBuilder.h
llvm/trunk/unittests/IR/IRBuilderTest.cpp
Index: llvm/trunk/include/llvm/IR/IRBuilder.h
===================================================================
--- llvm/trunk/include/llvm/IR/IRBuilder.h
+++ llvm/trunk/include/llvm/IR/IRBuilder.h
@@ -1931,10 +1931,17 @@
Value *CreateFPTrunc(Value *V, Type *DestTy,
const Twine &Name = "") {
+ if (IsFPConstrained)
+ return CreateConstrainedFPCast(
+ Intrinsic::experimental_constrained_fptrunc, V, DestTy, nullptr,
+ Name);
return CreateCast(Instruction::FPTrunc, V, DestTy, Name);
}
Value *CreateFPExt(Value *V, Type *DestTy, const Twine &Name = "") {
+ if (IsFPConstrained)
+ return CreateConstrainedFPCast(Intrinsic::experimental_constrained_fpext,
+ V, DestTy, nullptr, Name);
return CreateCast(Instruction::FPExt, V, DestTy, Name);
}
@@ -2046,6 +2053,29 @@
return Insert(CastInst::CreateFPCast(V, DestTy), Name);
}
+ CallInst *CreateConstrainedFPCast(
+ Intrinsic::ID ID, Value *V, Type *DestTy,
+ Instruction *FMFSource = nullptr, const Twine &Name = "",
+ MDNode *FPMathTag = nullptr,
+ Optional<ConstrainedFPIntrinsic::RoundingMode> Rounding = None,
+ Optional<ConstrainedFPIntrinsic::ExceptionBehavior> Except = None) {
+ Value *RoundingV = getConstrainedFPRounding(Rounding);
+ Value *ExceptV = getConstrainedFPExcept(Except);
+
+ FastMathFlags UseFMF = FMF;
+ if (FMFSource)
+ UseFMF = FMFSource->getFastMathFlags();
+
+ CallInst *C;
+ if (ID == Intrinsic::experimental_constrained_fpext)
+ C = CreateIntrinsic(ID, {DestTy, V->getType()}, {V, ExceptV}, nullptr,
+ Name);
+ else
+ C = CreateIntrinsic(ID, {DestTy, V->getType()}, {V, RoundingV, ExceptV},
+ nullptr, Name);
+ return cast<CallInst>(setFPAttrs(C, FPMathTag, UseFMF));
+ }
+
// Provided to resolve 'CreateIntCast(Ptr, Ptr, "...")', giving a
// compile time error, instead of converting the string to bool for the
// isSigned parameter.
Index: llvm/trunk/unittests/IR/IRBuilderTest.cpp
===================================================================
--- llvm/trunk/unittests/IR/IRBuilderTest.cpp
+++ llvm/trunk/unittests/IR/IRBuilderTest.cpp
@@ -125,10 +125,14 @@
TEST_F(IRBuilderTest, ConstrainedFP) {
IRBuilder<> Builder(BB);
Value *V;
+ Value *VDouble;
CallInst *Call;
IntrinsicInst *II;
+ GlobalVariable *GVDouble = new GlobalVariable(*M, Type::getDoubleTy(Ctx),
+ true, GlobalValue::ExternalLinkage, nullptr);
V = Builder.CreateLoad(GV->getValueType(), GV);
+ VDouble = Builder.CreateLoad(GVDouble->getValueType(), GVDouble);
// See if we get constrained intrinsics instead of non-constrained
// instructions.
@@ -159,6 +163,16 @@
II = cast<IntrinsicInst>(V);
EXPECT_EQ(II->getIntrinsicID(), Intrinsic::experimental_constrained_frem);
+ V = Builder.CreateFPTrunc(VDouble, Type::getFloatTy(Ctx));
+ ASSERT_TRUE(isa<IntrinsicInst>(V));
+ II = cast<IntrinsicInst>(V);
+ EXPECT_EQ(II->getIntrinsicID(), Intrinsic::experimental_constrained_fptrunc);
+
+ VDouble = Builder.CreateFPExt(V, Type::getDoubleTy(Ctx));
+ ASSERT_TRUE(isa<IntrinsicInst>(VDouble));
+ II = cast<IntrinsicInst>(VDouble);
+ EXPECT_EQ(II->getIntrinsicID(), Intrinsic::experimental_constrained_fpext);
+
// Verify the codepaths for setting and overriding the default metadata.
V = Builder.CreateFAdd(V, V);
ASSERT_TRUE(isa<ConstrainedFPIntrinsic>(V));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64934.210638.patch
Type: text/x-patch
Size: 3538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190718/97507633/attachment.bin>
More information about the llvm-commits
mailing list