[PATCH] D64923: [FileCheck]] Canonicalize caret location testing

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Readability is to some extent in the eye of the reader, so I've restrained myself to one suggestion. Otherwise this review is up to James.



================
Comment at: llvm/test/FileCheck/check-not-diaginfo.txt:6
 
-DIAG:         error: CHECK-NOT: excluded string found in input
-DIAG-NEXT:    CHECK-NOT: test
-DIAG-NEXT: {{^           \^}}
-DIAG-NEXT:    note: found here
-DIAG-NEXT:    CHECK-NOT: test
-DIAG-NEXT: {{^           \^}}
+DIAG:           error: CHECK-NOT: excluded string found in input
+DIAG-NEXT:      CHECK-NOT: test
----------------
Would this all be easier to read if you added `--match-full-lines` and then lined up the colons on each directive so the "full line" would start in the same place on each line?
Also then you would not need the leading `{{^}}` which should help clarify.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64923/new/

https://reviews.llvm.org/D64923