[PATCH] D64913: [yaml2obj] - Add a support for defining null sections in YAMLs.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 08:33:31 PDT 2019


MaskRay added a comment.

In the description:

> name string table section is contained in thesh_link field of the section header at index 0.

Typo: thesh_link -> the sh_link



================
Comment at: tools/yaml2obj/yaml2elf.cpp:135
 
+  // Non-zero when document explicitly describes SHT_NULL section
+  ELFYAML::Section *DocNullSec = nullptr;
----------------
Period at the end.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64913/new/

https://reviews.llvm.org/D64913





More information about the llvm-commits mailing list