[PATCH] D64923: [FileCheck]] Canonicalize caret location testing

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre created this revision.
thopre added reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk.
thopre added a project: LLVM.

Testing of caret location in diagnostic message is currently made with
CHECK directive with the following general format:
CHECK: {{^         \^$}}

James Henderson suggested the following would be more readable:
CHECK: {{^}}         ^

and when whole lines can be matched (as is the case for command-line
testing where error messages do not include path):
CHECK:         ^
using the option --match-full-lines.

This commit implements these 2 changes on all existing caret position
tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64923

Files:
  llvm/test/FileCheck/check-not-diaginfo.txt
  llvm/test/FileCheck/numeric-defines-diagnostics.txt
  llvm/test/FileCheck/numeric-expression.txt
  llvm/test/FileCheck/string-defines-diagnostics.txt
  llvm/test/FileCheck/verbose.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64923.210561.patch
Type: text/x-patch
Size: 13973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190718/0b69f067/attachment.bin>