[PATCH] D64908: Fix and test inter-procedural register allocation for ARM

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard marked an inline comment as done.
ostannard added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetRegisterInfo.h:493
+  /// Return a null-terminated list of all of the registers thich are clobbered
+  /// "inside" a call to the given function. For example, these might be needed
+  /// for PLT sequences of long-branch veneers.
----------------
arsenm wrote:
> Why aren’t these explicit clobbers on the call itself?
This is a property of the calling convention, not the BL instruction, so I think it makes more sense to have it here. I think we also use BL as a long branch inside Thumb1 functions, in which case it clobbers lr but nor r12.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64908/new/

https://reviews.llvm.org/D64908