[PATCH] D64405: [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added a comment.

In D64405#1589567 <https://reviews.llvm.org/D64405#1589567>, @jdoerfert wrote:

> In D64405#1585175 <https://reviews.llvm.org/D64405#1585175>, @ebrevnov wrote:
>
> > In D64405#1582896 <https://reviews.llvm.org/D64405#1582896>, @jdoerfert wrote:
> >
> > > Out of curiosity, would that still be broken with your example?
> >
> >
> > It should work. Main challenge I see here is how to perform "isBestPossible" check effectively so it doesn't introduce compile time slow down. Because when  this check fails we will have to perform full analysis in addition.
>
>
> Isn't `MemDepResult` type `Other` with `OtherType::NonFuncLocal` the best case possible? Checking for that one should be cheap, or am I missing something? Would you be willing to give it a try and see what the actual performance is?


I now see what you mean :-) I was thinking of a "bestResult" as best for load in current context. Sure will give it a try. Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64405/new/

https://reviews.llvm.org/D64405