[PATCH] D64882: [FileCheck] Fix numeric variable redefinition

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D64882#1591189 <https://reviews.llvm.org/D64882#1591189>, @thopre wrote:

> In D64882#1591158 <https://reviews.llvm.org/D64882#1591158>, @jhenderson wrote:
>
> > LGTM.
>
>
> I think I'll add unit tests as well.


Nvm, one issue is an assert and the other needs to test the diagnostic message, both aspects being difficult to test in unit testing. There's already tests for those so I'll leave it like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64882/new/

https://reviews.llvm.org/D64882