[PATCH] D62997: [LV] Share the LV illegality reporting with LoopVectorize. NFC.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 18 03:34:04 PDT 2019


rengolin added a comment.

In D62997#1591113 <https://reviews.llvm.org/D62997#1591113>, @psamolysov wrote:

> @hsaito The test `no_switch.ll` failed because remarks aren't written now by default, so without `-pass-remarks-analysis`.  I've just removed the corresponding check from the test. But, I think, the NFC label from diff/commit should also be removed in this case because the behavior is changed a little bit. No other problems with tests in the `LoopVectorize` directory. If this diff is applied, the entire set of tests passes.


This is also not NFC because it changes the option name. In that case, we need to take a longer look and make sure it won't break anyone else and maybe even consider warning the community (which heavily uses opt around).

So, I'd recommend we don't change the name of the pass on this patch, keep the remark and maintain the NFC tag.

If we want to change the name, or behaviour, we can do so later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62997/new/

https://reviews.llvm.org/D62997





More information about the llvm-commits mailing list