[PATCH] D64882: [FileCheck] Fix @LINE substitution in error msg
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 18 02:19:31 PDT 2019
thopre added a comment.
In D64882#1590970 <https://reviews.llvm.org/D64882#1590970>, @jhenderson wrote:
> I am wondering why we don't just have `setValue` call `clearValue` first in all cases?
That's a remnant when each variable definition had its own variable and thus setting it twice didn't make sense and indicated an error. I think the right thing to do now is to change setValue to not check if the value is already set or not.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64882/new/
https://reviews.llvm.org/D64882
More information about the llvm-commits
mailing list