[PATCH] D64880: ELF: Allow forward references to linked sections.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 19:30:19 PDT 2019


pcc added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:657
+
+  for (size_t i = 0, e = objSections.size(); i < e; i++) {
+    if (this->sections[i] == &InputSection::discarded)
----------------
MaskRay wrote:
> This can be changed to a range-based for.
We're iterating over two arrays here (`this->sections` and `objSections`) which makes it simpler to use a regular for loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64880/new/

https://reviews.llvm.org/D64880





More information about the llvm-commits mailing list