[PATCH] D64898: Standardize how we check for legality of frame realignment

Wed Jul 17 17:29:45 PDT 2019

reames updated this revision to Diff 210468.
reames added a comment.

Highlight the change in behaviour for over aligned allocas w/o stack realignment.

The result is a bit counter intuitive.  We generate a variable size frame, but not one with realignment.  Not really sure this is any better, but at least it's consistent with frames which aren't realignable as a target property?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64898/new/

https://reviews.llvm.org/D64898

Files:
  include/llvm/CodeGen/TargetFrameLowering.h
  lib/CodeGen/MachineFunction.cpp
  lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
  lib/CodeGen/TargetRegisterInfo.cpp
  test/CodeGen/X86/alloca-overaligned.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64898.210468.patch
Type: text/x-patch
Size: 4368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190718/f24fc7f0/attachment.bin>