[PATCH] D64887: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or destruction'

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 15:04:24 PDT 2019


thegameg added a comment.

In D64887#1590340 <https://reviews.llvm.org/D64887#1590340>, @dendibakh wrote:

> In D64887#1590334 <https://reviews.llvm.org/D64887#1590334>, @thegameg wrote:
>
> > LGTM, thanks! Not sure how I missed this test.
>
>
> Can you please double check on your side that it fails without this change?


I don't have a setup where this test is supported, but the error and the fix look pretty obvious to me.

What I meant was that I'm not sure how I missed the bots failing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64887/new/

https://reviews.llvm.org/D64887





More information about the llvm-commits mailing list