[PATCH] D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: cmake/modules/CrossCompile.cmake:58
         -DCMAKE_MAKE_PROGRAM="${CMAKE_MAKE_PROGRAM}"
         ${CROSS_TOOLCHAIN_FLAGS_${target_name}} ${CMAKE_SOURCE_DIR}
         -DLLVM_TARGET_IS_CROSSCOMPILE_HOST=TRUE
----------------
smeenai wrote:
> You'll wanna change this one to read from a project-specific cache variable too. You'll also wanna preserve backwards compatibility for the people using the old spelling.
I think you probably want to make `CROSS_TOOLCHAIN_FLAGS_${target_name}` generic, not project specific, and only add a project-specific variant if it is needed.

It is entirely possible to use the cross-compile code to generate multiple different cross-projects for the same target where you do want the same target flags, because those flags relate to the target not the project you're building.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64837/new/

https://reviews.llvm.org/D64837