[PATCH] D63488: [docs] Phabricator, not the lists is the main entry point for new patches

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 17 12:14:56 PDT 2019


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I will be willing to LGTM this, but first, a couple of suggested changes.



================
Comment at: docs/DeveloperPolicy.rst:101
+component of the LLVM bug tracker, but the Phabricator is the primary place for
+reviews and should generally be preferred.
 
----------------
I'm fine with the change of tone, but deleting the specific mailing list advise about how to do so is probably a poor idea.  It'd be good to shift those two paragraphs past the one about confidential information, and maybe lead in with something along the lines of:

It is also acceptable to submit patches directly to the llvm-commit mailing list.  We discourage this for new users though as it less likely your patch will be seen by motivated reviewers as many who watch for contributions from new contributors rely on phabricator for filtering.  


================
Comment at: docs/Phabricator.rst:16
 added as a subscriber on all reviews, and Phabricator users should be prepared
 to respond to free-form comments in mail sent to the commits list.
 
----------------
Addition: Such comments are almost always mirrored into phabricator automatically, but sometimes the scripting isn't quite perfect.  Please check manually before committing.  


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63488/new/

https://reviews.llvm.org/D63488





More information about the llvm-commits mailing list