[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp:55
+  for (auto &Symbol : O.SymTable.Symbols) {
+    Symbol->Index = Index;
+    Index++;
----------------
   Symbol->Index = Index++;


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp:75
+  uint32_t NumExtDefSymbols = 0;
+  for (; Iter != End; Iter++) {
+    if (((*Iter)->n_type & MachO::N_TYPE) == MachO::N_UNDF)
----------------
alexshap wrote:
> nit: ++Iter
and the same above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63395/new/

https://reviews.llvm.org/D63395