[PATCH] D63713: Add error handling to the DataExtractor class

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

I'm happy, but other people obviously have better eyesight than I do.  Give Jonas and Blaikie a day to chime in, I think.



================
Comment at: unittests/Support/DataExtractorTest.cpp:10
 #include "llvm/Support/DataExtractor.h"
+#include "llvm/Testing/Support/Error.h"
 #include "gtest/gtest.h"
----------------
labath wrote:
> probinson wrote:
> > The Error is part of the DataExtractor interface, you should not need to #include this here.
> This is the testing support header which defines stuff that makes things like `EXPECT_THAT_ERROR(..., Succeeded())` work.
Doh!  I'm due for an eye test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63713/new/

https://reviews.llvm.org/D63713