[PATCH] D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities.

Wed Jul 17 04:23:24 PDT 2019

sgraenitz added a comment.

In D64609#1588668 <https://reviews.llvm.org/D64609#1588668>, @lhames wrote:

> The main wrinkle is the remote tests: orc-lazy is currently running in-process only, so these tests aren’t properly testing remote-jitting support.
>  Long term I would like to reconsider these tests. They were added in an ad-hoc fashion and many would now be better expressed as rtdyld or jitlink tests (neither of which were available at the time).

Right. Maybe that should happen before the deprecated code is actually removed.

> I will see if I can get the remote-execution utility working with orc-lazy mode. That probably won’t make the branch cut-off, but hopefully can be done soon enough that we can cherry-pick before the 9.0 release.

If that's a low-hanging fruit why not. Otherwise features might be better deferred to the next release?

> [...] perhaps the best option would be to pull them in under a new directory name (OrcLazy-LegacyTests?) in LLVM 9.0.

Well, after all LLVM 9.0 has OrcMCJITReplacement. Thinking again, maybe it's best to leave these tests untouched for the current release and review them during the 10.0 time frame. Once all OrcMCJIT tests are sorted out, saying bye bye to ORCv1 sounds reasonable to me.

> I’m going to land this. There may be fallout to example programs and other LLVM projects and want to try to shake that out before the 9.0 branch gets cut.

Agree, thanks for working on this!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64609/new/

https://reviews.llvm.org/D64609