[PATCH] D64845: [GlobalISel] Check LLT size matches memory size for non-truncating stores.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 19:12:32 PDT 2019
aemerson marked an inline comment as done.
aemerson added inline comments.
================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3314
+ InsnMatcher.addPredicate<MemoryVsLLTSizePredicateMatcher>(
+ 0, MemoryVsLLTSizePredicateMatcher::EqualTo, 0);
+ }
----------------
arsenm wrote:
> Should also continue? Could make this a select on the match type to the one addPredicate call
Yeah, just seen this doesn't work. I'm not familiar with this code, but how do non-truncstore predicates end up on trunc stores such that it breaks?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64845/new/
https://reviews.llvm.org/D64845
More information about the llvm-commits
mailing list