[PATCH] D64759: [CodeGen] Don't resolve the stack protector frame accesses until PEI

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 17:40:33 PDT 2019


thegameg added a comment.

In D64759#1588217 <https://reviews.llvm.org/D64759#1588217>, @efriedma wrote:

> It's hard for me to imagine a scenario where this actually makes stack protection substantially more effective; if you have a wild write, presumably you can use it to do something more useful than just corrupt the address of the guard.  But I guess the performance cost is small.


The only important thing I see is that it can be used to bypass the stack protector.

> Is it possible for register scavenging to scavenge the register containing the address of the guard after the frame index is resolved?

I am looking into this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64759/new/

https://reviews.llvm.org/D64759





More information about the llvm-commits mailing list