[PATCH] D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android

[Ziang Wan via Phabricator via llvm-commits]

ziangwan marked 2 inline comments as done.
ziangwan added inline comments.


================
Comment at: CMakeLists.txt:186
 if(NOT DEFINED TARGET_OS)
-  message(STATUS "Check target operating system - ${CMAKE_SYSTEM_NAME}")
-  set(TARGET_OS ${CMAKE_SYSTEM_NAME})
+  # FIXME: Currently there is a compatibility issue between Android NDK and cmake
+  # Therefore, we check for TEST_SUITE_REMOTE_CLIENT==adb to know whether
----------------
danalbert wrote:
> Got a link to a bug? `CMAKE_SYSTEM_NAME` should be `Android` for Android.
Resolved by using NDK's android.toolchain.cmake file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64427/new/

https://reviews.llvm.org/D64427