[PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 14:40:35 PDT 2019


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197
+    find_package(PythonInterp REQUIRED)
+    find_package(PythonLibs REQUIRED)
+  endif()
----------------
mgorny wrote:
> As a small optimization, I think you can prepend major+minor version into `Python_ADDITIONAL_VERSIONS`. Then it will prefer finding the same libs as interpreter.
The implementation of `PythonLibs` should already honor the minor/major version it gets from the interpreter: https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake#L116


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64812/new/

https://reviews.llvm.org/D64812





More information about the llvm-commits mailing list