[PATCH] D64819: Modified reassociate-after-unroll.ll to use regex basic block names.

Whitney via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 14:37:17 PDT 2019


Whitney marked an inline comment as done.
Whitney added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/reassociate-after-unroll.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; REQUIRES: powerpc-registered-target
----------------
lebedev.ri wrote:
> Whitney wrote:
> > lebedev.ri wrote:
> > > Is that what the script produces?
> > Do you mean this line, the original LIT test, or the modified LIT test?
> > The new changes are manually modified by me.
> Ah, so it's https://bugs.llvm.org/show_bug.cgi?id=41532
> But still, the solution is to just rerun the script when that happens,
> otherwise these changes will simply be lost when it will be rerun.
I will address the issue in the script at a later date and try to provide a fix for PR41532, but for now I have this test case failing unnecessarily in an out-of-tree target. So I’d like to proceed with the interim fix to the test case for the time being.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64819/new/

https://reviews.llvm.org/D64819





More information about the llvm-commits mailing list