[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

[Ben Hamilton via Phabricator via llvm-commits]

benhamilton added a comment.

Submitted as r366267. Thanks!



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:389
   bool isCpp11AttributeSpecifier(const FormatToken &Tok) {
     if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square))
       return false;
----------------
aaron.ballman wrote:
> Clang has a feature flag to enable support for double-square bracket attributes in more than just C++ mode, and this is enabled by default in C2x mode. This check for `isCpp()` makes me suspect we may be doing the wrong thing here.
Good point. I filed https://bugs.llvm.org/show_bug.cgi?id=42645 to revisit this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64632/new/

https://reviews.llvm.org/D64632