[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 13:56:58 PDT 2019


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:400
+      StringRef name = segment->getName();
+      if (name.startswith(".tdata.") || name.startswith(".tbss."))
+        tlsUsed = true;
----------------
Right now we always compiler with -fdata-sections, but if we didn't then object files might have just one ".tdata" sections.   Perhaps drop the final "."?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64537/new/

https://reviews.llvm.org/D64537





More information about the llvm-commits mailing list