[PATCH] D64817: [CMake] Fix LLVM build non-determinism on RHEL
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 13:56:54 PDT 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:155
+ # Version 2.23 is the first version of binutils where both ar and ranlib have the D flag
+ if("${CMAKE_MATCH_0}" VERSION_GREATER "2.22")
+ set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> Dqc <TARGET> <LINK_FLAGS> <OBJECTS>")
----------------
Checking for > 2.22 introduces the possibility that the check passes for patch/fix levels of 2.22 when we actually cared about 2.23.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64817/new/
https://reviews.llvm.org/D64817
More information about the llvm-commits
mailing list