[PATCH] D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-hash-symbols.test:78
 
+# RUN: yaml2obj --docnum=2 %s -o %t1-x86_64.o
+# RUN: llvm-readelf --hash-symbols %t1-x86_64.o | FileCheck %s --check-prefix HASH-X86-64
----------------
jhenderson wrote:
> I don't think it's the x86_64 bit that's important, if I'm not mistaken, merely the 64-bit nature of the ELF, so perhaps simplify the above i386 naming to simply "32" and this x86_64 to simply "64".
Just a reminder: `.so` (or just delete the `.o` suffix)


================
Comment at: test/tools/llvm-readobj/elf-hash-symbols.test:155
 ## Show that if there are no hash sections, we do not print anything.
-# RUN: yaml2obj --docnum=2 %s -o %t2.o
-# RUN: llvm-readelf --hash-symbols %t2.o \
+# RUN: yaml2obj --docnum=3 %s -o %t3.o
+# RUN: llvm-readelf --hash-symbols %t3.o \
----------------
`%t3.so`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64788/new/

https://reviews.llvm.org/D64788