[PATCH] D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 04:23:17 PDT 2019
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, although you still have to rebase it past the change to camelBack casing of variables :-)
================
Comment at: lld/test/COFF/dllexport-mingw.s:5
-# RUN: lld-link -lldmingw -dll -out:%t.dll -entry:main %t.obj -implib:%t.lib
+# RUN: lld-link -safeseh:no -lldmingw -dll -out:%t.dll -entry:main %t.obj -implib:%t.lib
# RUN: llvm-readobj %t.lib | FileCheck %s
----------------
Aren't many of the test changes redundant, in the places where we have `-lldmingw`? Although it might be good for consistency...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63570/new/
https://reviews.llvm.org/D63570
More information about the llvm-commits
mailing list